Should link protobuf (prevent #3)

akihikodaki / cld3-ruby

cld3-ruby is an interface of Compact Language Detector v3 (CLD3) for Ruby.

Apache License 2.0

77 stars 22 forks source link

Closed esetomo closed 7 years ago

esetomo commented 7 years ago

When "-lprotobuf" can not be added to LIBS, installation is canceled. This prevents installation of broken binary.

esetomo commented 7 years ago

too complex. rewrite.

akihikodaki commented 7 years ago

I think it is OK even if it doesn't have a checking message because:

RubyGems, which ignores stdout, is likely to be used for installation.
mkmf emits mkmf.log, which is useful enough to investigate an issue which you encountered.
Follow the rule of silence.