Internationalise banner message

akiko-pusu / redmine_banner

Maintenance Repository - https://github.com/agileware-jp/redmine_banner

GNU General Public License v2.0

98 stars 53 forks source link

Internationalise banner message #105

Open dnyamy opened 5 years ago

dnyamy commented 5 years ago

Hello, I have just discovered this plugin Thanks a lot for the work done

I will nevertheless have one need. My users speak various language ?

Is there a way to configure/tweak it to have the right message displayed to each user according to his language ?

Thanks dn

akiko-pusu commented 5 years ago

Hi, thanks for your reporting. I'm sorry now banner can only hold a message which does not support multilingual message.

But personally, I think this request is interesting to me :) Now you can set a global banner and project scope one. Which banner do you hope to support internationalization first?

DarkSideGeek commented 5 years ago

I’m still on an older version — is Redmine itself multi-lingual now? Because if not, IMHO we should start there. Make the language be a profile choice rather than a global setting. Then the builtins will be more dynamic and you can extend that to Banner. It’s probably unrealistic to expect wikis and issue texts to be also, because that would be a lot of editing...

On Jul 27, 2019, at 6:46 AM, Akiko Takano notifications@github.com wrote:

Hi, thanks for your reporting. I'm sorry now banner can only hold a message which does not support multilingual message.

But personally, I think this request is interesting to me :) Now you can set a global banner and project scope one. Which banner do you hope to support internationalization first?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

dnyamy commented 5 years ago

Reply to akiko-pusu, I need a multilingual banner first at global scope. Project scope internationalisation can wait. Thanks dn

akiko-pusu commented 5 years ago

@DarkSideGeek Thanks for your comment. I'm sorry if I can't figure out what you say...

On Redmine, each user can choose their preferred language. So, I think it's better that administrator can set multi-language banner messages per one topic with language informations.

Exp.

banner_type: info
default_message: Hello
- This is a default message displayed to anonymous user or to user who has not defined the preferred language yet.
- Default message is mandatory.
ja_message: こんにちは
- This message is shown if user prefers Japanese.
- Language specified message is an optional one.

To implement this feature, personally I have to refactor the data model to store global banner message, because now the global banner message is stored Settings table as serialized data. (Maybe need to define some tables)