search

akinomyoga / ble.sh

Bash Line Editor―a line editor written in pure Bash with syntax highlighting, auto suggestions, vim modes, etc. for Bash interactive sessions.
BSD 3-Clause "New" or "Revised" License
2.33k stars 77 forks source link

Sabbrev expansions not working #437

Closed dgudim closed 2 months ago

dgudim commented 2 months ago 
GNU bash, version 5.2.26(1)-release (x86_64-pc-linux-gnu) [EndeavourOS]
ble.sh, version 0.4.0-devel4+56765251 (noarch) [git 2.44.0, GNU Make 4.4.1, GNU Awk 5.3.0, API 4.0, PMA Avon 8-g1, (GNU MPFR 4.2.1, GNU MP 6.3.0)]
bash-completion, version 2.11 (hash:2d02f73e803daa87a06e94e33b2a7b3e672a2c0c, 76338 bytes) (noarch)
fzf key-bindings, (hash:a290e4cad579d5ad896110460a6d6317694c80f5, 5299 bytes) (noarch) (integration: on)
fzf completion, (hash:44bb904d396f8f266c609002cf49b563375ffaf5, 16128 bytes) (noarch) (integration: on)
zoxide, version 0.9.4 (/usr/bin/zoxide)
atuin, version 18.2.0 (/usr/bin/atuin)
locale: LANG=en_US.UTF-8 LC_ADDRESS=en_US.UTF-8 LC_IDENTIFICATION=en_US.UTF-8 LC_MEASUREMENT=ru_RU.UTF-8 LC_MONETARY=lt_LT.UTF-8 LC_NAME=en_US.UTF-8 LC_NUMERIC=en_US.UTF-8 LC_PAPER=en_US.UTF-8 LC_TELEPHONE=lt_LT.UTF-8 LC_TIME=ru_RU.UTF-8
terminal: TERM=xterm-256color wcwidth=15.0-west/15.1-2+ri, konsole:220380 (1;115;0)

After a recent update sabbrev expansions from integration/fzf-git no longer work. Typing gb and pressing space does nothing. (Edit: seems like my own sabbrevs also don't work 🤔)

Relevant parts of the config


bleopt edit_magic_expand=history:sabbrev

ble-import -d integration/fzf-completion
ble-import -d integration/fzf-key-bindings
_ble_contrib_fzf_git_config=sabbrev
ble-import -d integration/fzf-git
dgudim commented 2 months ago

After updating today to 0.4.0-devel4+70a325f9 my sabbrevs work again, but not ones from fzf-git

akinomyoga commented 2 months ago

Thank you for the report and sorry for the delay. I pushed a fix 70a325f95882f4850818542fc48b9ebb5db476bb in the master. Could you update ble.sh by running ble-update and check it?

dgudim commented 2 months ago

Still seeing the same issue

dgudim commented 2 months ago

test

akinomyoga commented 2 months ago

Ah, OK. I misunderstood your previous reply. I'll take a look.

akinomyoga commented 2 months ago

It works in my environment. Did it work before commit d66e05d2d5b57e8f5ff5931660b9796fdc86693f (which introduced the bug this time)?

Maybe you test it outside a git repository? The fzf-git sabbrevs generate empty results if you induce them outside a git repository.

dgudim commented 2 months ago

Damn, yes. Forgot about that part 🙃. Thanks! This can be closed then

akinomyoga commented 2 months ago

OK! Thank you for the report!