search

akinomyoga / cxxmatrix

C++ Matrix: The Matrix Reloaded in Terminals (Number falls, Banners, Matrix rains, Conway's Game of Life and Mandelbrot set)
MIT License
692 stars 76 forks source link

Update README.md #14

Closed cowboy8625 closed 3 years ago

akinomyoga commented 3 years ago

Thank you for your feedback! Hmm, but I'm not sure if I should merge this. There are two problems:

1) You have updated the number of only one specific project, which leads to unfair comparison. Currently, I update the numbers of stars all at once when I make changes to cxxmatrix so that the list compares the number of stars at the moment when cxxmatrix is last modified. The current list is updated on 4th, September. If we update the number of stars of only a part of the projects, we cannot simply compare the numbers because they are the numbers measured at different times, which is unfair. It should be noted that all the projects with sufficient stars acquired considerable numbers of new stars after 4th, Sep.

2) The second problem is that, if we start to accept this kind of PR, we need to update README every time some project acquires a new star. For example, are you going to submit a PR every time your project gets a new star? I think the essential question is "Do we really need to keep up-to-date with the list?" The main part of cxxmatrix is not the list in README, but the program cxxmatrix, so honestly, I wouldn't like to clutter the git history with such commits.

cowboy8625 commented 3 years ago

Welp that makes perfect sense to me. Yeah that was kind of selfish to just update my own. You have in spired me to furth work on my own project.

akinomyoga commented 3 years ago

I have made a commit 87f1fb0 for misc changes and also updated the list in README, so now the number of stars of your repository is also up to date!