akinsho / bufferline.nvim

A snazzy bufferline for Neovim
GNU General Public License v3.0
3.46k stars 195 forks source link

docs: fix lua codes, consistent nerdfonts symbols, formatting #922

Closed gepbird closed 2 months ago

gepbird commented 3 months ago

The last formatting commit 7eb332650221951c5c61adad8f3be6ad2e5a2bcb has a much bigger diff than the other commits, please review commit-by-commit rather than all commits at the same time to make it easier for yourself :)

Let me know if you prefer another style for lua code in docs, I mostly followed the project's stylua.toml with a few exceptions:

akinsho commented 2 months ago

Hi @gepbird,

These appear to be a lot of stylistic changes mixed in with some more important fixes. Can we just address the crucial fixes first in a minimal PR just aimed at those then discuss any style changes as a followup. In general a lot of the attempts to add booleans and things like that are actually contrary to my intentions. The reason I added them like that was actually to specifically discourage copy-pasting which ends up being a huge cause of issues for me since if the code is clearly not copy-pastable people tend to add things in themselves rather than copy a huge blob then complain it doesn't work as they expect

gepbird commented 2 months ago

Sure, I'll break these changes up to multiple PRs.