akinsho / toggleterm.nvim

A neovim lua plugin to help easily manage multiple terminal windows
GNU General Public License v3.0
4.21k stars 170 forks source link

[BUG] images support bug? #520

Closed diegoulloao closed 9 months ago

diegoulloao commented 9 months ago

Is there an existing issue for this?

Current Behavior

Sorry if this bug is not related to this project. But for some reason toggleterm is not able to display embed images.

I'm using spotify inside toggleterm, and is looking like this:

Screenshot 1

Should look like this:

Screenshot 2

Expected Behavior

See embed images like running spotify_player in a normal terminal window.

Steps To Reproduce

  1. Install spotify_player: https://github.com/aome510/spotify-player with --features image flag
  2. Create the terminal instance for spotify:
    
    -- spotify terminal
    local spotify_term = Terminal:new({
    cmd = "spotify_player",
    display_name = "spotify",
    hidden = false,
    float_opts = {
    border = "none",
    },
    on_open = function()
    vim.cmd([[ startinsert! ]])
    end,
    })

-- global: spotify term toggle function _G.spotify_toggle() spotify_term:toggle() end

-- keybinding vim.keymap.set({ "n", "t" }, "", "lua spotify_toggle()")

4. Open `spotify_player` in a normal terminal window (check for the image)
5. Open the spotify terminal instance that we created and check for the image

### Environment

```Markdown
- OS: macOs Sonoma 14.1
- neovim version: NVIM v0.9.4
- Shell: zsh
- Terminal: iTerm2

Anything else?

Sorry if this bug doesn't belong here 🙏🏻. If not, any idea on why is not working?

See it in action here (enable audio), is cool af:

https://github.com/akinsho/toggleterm.nvim/assets/45423661/6d903f70-1a8a-4105-afc1-1f1401442391

Thanks.

akinsho commented 9 months ago

This problem is at the neovim level not this plugin. Currently neovim cannot show images inside the editor without some plugin like hologram.nvim or image.nvim. In either case this isn't a problem that this plugin can solve

diegoulloao commented 9 months ago

This problem is at the neovim level not this plugin. Currently neovim cannot show images inside the editor without some plugin like hologram.nvim or image.nvim. In either case this isn't a problem that this plugin can solve

Sure. I already tried installing hologram.nvim, but it didn't work. Thank you!