search

akinsho / toggleterm.nvim

A neovim lua plugin to help easily manage multiple terminal windows
GNU General Public License v3.0
4.21k stars 170 forks source link

fix: add rate limit for repeated ToggleTerm trigger #537

Closed ysy closed 7 months ago

ysy commented 7 months ago

Issue: when terminal_mapping is enabled and key-mapping is 'Ctrl + \', if I hold 'Ctrl + \' for long time, ToggleTerm command will be triggerd repeatly(show and hide for floating terminal). If the combo-key(Ctrl + ) is released slightly slower(depend on keyboard), ToggleTerm will be triggered twice, causing the floating terminal window to briefly appear and then immediately hide again.

To address the above issue, I have implemented a delay mechanism that checks the time difference between the current ToggleTerm and the previous one. If the difference is less than 150ms, it will be ignored.

This modification is quite dirty, and I hope it can serve as a starting point for further improvements.

akinsho commented 7 months ago

Hi @ysy, I'm not sure why this is necessary at all? why are holding down the terminal toggle mapping so much? I really can't envision the use case for this. I developed this plugin around the idea that a person would create one terminal then maybe a little while later make another and so on. I don't know why the key would need to be spammed?

I think this might be too specific a use case to get added to the plugin itself

akinsho commented 7 months ago

This also seems like something you could just add to your vim config rather than here. I don't think many people share this issue.