akinsho / toggleterm.nvim

A neovim lua plugin to help easily manage multiple terminal windows
GNU General Public License v3.0
4.06k stars 170 forks source link

[BUG] toggleterm changing terminal width strangely with `signcolumn = "yes"` #582

Open wenjinnn opened 2 months ago

wenjinnn commented 2 months ago

Is there an existing issue for this?

Current Behavior

When setting hide_numbers = true and have vim.opt.signcolumn = "yes", open some full screen app, it renders beyond the screen, e.g. lazygit image and if I press tab to switch to next lazygit window, It will looks like: image this happened after I upgrade to nvim 0.10, now I'm setting hide_numbers to false, and add a on_open hook to achieve the same behavior and it work well:

        on_open = function()
          local ol = vim.opt_local
          ol.number = false
          ol.signcolumn = "no"
          ol.relativenumber = false
        end,

Expected Behavior

Work like normal terminal

Steps To Reproduce

  1. Toggleterm with direction horizontal, not sure if other direction have the same issue
  2. Have vim.opt.signcolumn = "yes"
  3. Open toggleterm and run lazygit in terminal

Environment

- OS: NixOS 23.11
- neovim version: 0.10
- Shell: zsh

Anything else?

No response