search

akira / exq

Job processing library for Elixir - compatible with Resque / Sidekiq
Other
1.51k stars 182 forks source link

Redis auth support #53

Closed akira closed 9 years ago

j-mcnally commented 9 years ago

Should we just support REDIS_URL?

redis://user:pass@host:port/database

akira commented 9 years ago

Yeah that would work

optikfluffel commented 9 years ago

What's the status on this one?

akira commented 9 years ago

I haven't had a chance to look at this - it's open to take a crack at. If you need this quick, I can add an extra param for the auth for now. I probably won't get a chance to look at the URL based approach until this/next weekend unless you get to it first.

optikfluffel commented 9 years ago

I just saw that Redis only supports authentication via password (no user), so the URI should be something more like redis://:password@host:port/database. Also using artemeff/exredis would maybe be a good idea, they already have a start_using_connection_string method, but then all the eredis calls would have to be changed. (Or copy theirs and add a nice comment with some :heart:s and a link) xD

akira commented 9 years ago

@optikfluffel I just realized that Redis AUTH is already supported as an option, it is 'password' on the config params, I updated README. Closing this, and added #71.