search

akiradeveloper / akashic-storage

Filey system backed S3-compatible storage in Scala/Akka-Http
Apache License 2.0
22 stars 2 forks source link

s3-tests degrade (after bucket name check) #109

Closed akiradeveloper closed 8 years ago

akiradeveloper commented 8 years ago

At commit https://github.com/akiradeveloper/akashic-storage/commit/8275c4ca070aa01978a9b3c1c7d0bd759b4b2e46

there is a huge degradation in s3-tests result. The difference is

(diff before after)

< ERROR: s3tests.functional.test_s3.test_bucket_create_naming_bad_long

---
> ERROR: s3tests.functional.test_s3.test_bucket_create_naming_good_long_250
> ERROR: s3tests.functional.test_s3.test_bucket_create_naming_good_long_251
> ERROR: s3tests.functional.test_s3.test_bucket_create_naming_good_long_252
> ERROR: s3tests.functional.test_s3.test_bucket_create_naming_good_long_253
> ERROR: s3tests.functional.test_s3.test_bucket_create_naming_good_long_254
> ERROR: s3tests.functional.test_s3.test_bucket_create_naming_good_long_255
> ERROR: s3tests.functional.test_s3.test_bucket_list_long_name
> ERROR: s3tests.functional.test_s3.test_bucket_create_naming_dns_long

< FAIL: s3tests.functional.test_s3.test_bucket_create_naming_bad_short_one
< FAIL: s3tests.functional.test_s3.test_bucket_create_naming_bad_short_two
< FAIL: s3tests.functional.test_s3.test_bucket_create_naming_bad_ip

---
> FAIL: s3tests.functional.test_s3.test_bucket_create_naming_bad_long

My guess is, the commit resolves bad_long and this is good. but as the side effect it broke good_long tests. I don't know what these tests do actually.

akiradeveloper commented 8 years ago

http://docs.aws.amazon.com/AmazonS3/latest/dev/BucketRestrictions.html

akashic-storage only allows DNS-compliant names