search

akirak / bookmark-frecency.el

Sort Emacs bookmarks by frecency
GNU General Public License v3.0
4 stars 2 forks source link

No change in bookmark list #5

Closed ghost closed 10 months ago

ghost commented 10 months ago

I installed the package and added this to my dot emacs:

(bookmark-frecency-mode 1)
(setq bookmark-sort-flag 'last-modified)

I don't have dashboard installed. If I invoke my bookmark-bmenu-list the list remains static and no changes are made to the order. Does the package only order if dashboard is installed?

akirak commented 10 months ago

@emacs-elements Unless you have visited at least one bookmark while the global mode is on, it is the same as sorting by modification time, i.e. recency. Did you visit a bookmark?

ghost commented 10 months ago

Yes, I did. I visited several.

akirak commented 10 months ago

@emacs-elements What Emacs version are you using? Is bookmark-bmenu--revert function using bookmark-maybe-sort-alist function to retrieve the bookmark records?

ghost commented 10 months ago

GNU Emacs 29.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.18.0)

Yes, it appears so:

(defun bookmark-bmenu--revert ()
  "Re-populate `tabulated-list-entries'."
  (let (entries)
    (dolist (full-record (bookmark-maybe-sort-alist))...
akirak commented 10 months ago

At least on my computer (Emacs head), bookmark-frecency-mode works, even on bookmark-bmenu-list.

If you open your bookmark-default-file, does it contain x-frecency-access-count in some of the entries?

ghost commented 10 months ago

It's working now! Thanks for your help.

akirak commented 10 months ago

I'm glad that you have successfully used my package. If you have any problem, please feel free to open a ticket.

akirak commented 10 months ago

@emacs-elements That's great, thanks! I can't believe someone has created a video for my package!