search

akirak / elinter

Nix-based CI and local testing framework for Emacs Lisp projects
GNU General Public License v3.0
18 stars 2 forks source link

Add success message for melpa-check-init-project #9

Closed ericdallo closed 4 years ago

akirak commented 4 years ago

Thank you for sending this first PR.

It may be a good idea to display a message on successful configuration. However, I don't think it is common to print a colored message to the *Messages* buffer. Even if it is, it would be better to provide a custom face so the user can tweak it to suit his theme.

I was also thinking of visiting the buffer of packages.dhall after configuration. What do you think?

Anyway, it's always nice to have an extensive feedback at an early phase. And thank you for your patience for one month.

ericdallo commented 4 years ago

No problem, I think it makes sense go to the packages.dhall. I don't see any restriction about colors on message buffer, lsp-mode uses it on every message :stuck_out_tongue: but I agree in moving to a custom defface.

akirak commented 4 years ago

Thanks.