webkit-module needs to be compiled

[matteha]

Fantastic package! I am using DOOM emacs 28 native comp, and using the straight recipe mentioned:

(straight-use-package
 '(webkit :type git :host github :repo "akirakyle/emacs-webkit"
          :branch "main"
          :files (:defaults "*.js" "*.css")
          :build ("make")))

and tried below as well:

(straight-use-package
 '(webkit :type git :host github :repo "akirakyle/emacs-webkit"
          :branch "main"
          :no-byte-compile t
          :files (:defaults "*.js" "*.css")
          :build ("make")))

but it keeps giving me the error:

if: webkit needs ‘webkit-module’ to be compiled!

Although I do have the webkit-module.so compiled by straight:

➜  emacs-webkit git:(main) ✗ pwd
/home/linux/.emacs.d/.local/straight/repos/emacs-webkit
➜  emacs-webkit git:(main) ✗ ls -latrah webkit-module.so
-rwxrwxr-x. 1 linux linux 49K Nov 22 22:52 webkit-module.so
➜  emacs-webkit git:(main) ✗ 

[bqv]

I'm willing to bet its just not being put in the right place. Fiddle webkit-base-dir?

[matteha]

webkit--base is a variable without a source file.

Value "/home/linux/.emacs.d/.local/straight/repos/emacs-webkit/"

[akirakyle]

Can you try loading it directly with (module-load "/path/to/module.so")?

[MagicRB]

Adding "*.h" "*.c" "Makefile" to the :files section fixed it for me, straight only includes .js and .css files as instructed, which prevents the module from building

[akirakyle]

Ah I haven't had the chance to test the straight recipe myself so sorry for the omission. I'll update the readme

[MagicRB]

Happy to help, this seems to me as a really cool project!