search

akirakyle / emacs-webkit

An Emacs Dynamic Module for WebKit, aka a fully fledged browser inside emacs
GNU General Public License v3.0
419 stars 24 forks source link

Update default.nix #30

Closed lambdadog closed 3 years ago

lambdadog commented 3 years ago

More idiomatic callPackage-ing from any emacsPackages set, including generated ones.

I chose to rename src and version due to an src attribute already existing in pkgs, which would lead to it being passed as an argument if emacsPackages.callPackage was called on it. I'd honestly like to remove the arguments, but I imagine you have them in place for a reason so I won't mess with them without a :+1: from you.

Closes #29.

akirakyle commented 3 years ago

Pinging @bqv since he's the one who actually wrote the default.nix (I'm still using horrible hacks to make this work on nix).

bqv commented 3 years ago

Mess with them all you like, they're just there so it's hackable as an initial working copy. Your changes look smart 👍

lambdadog commented 3 years ago

@akirakyle good to merge then?