akirakyle / emacs-webkit

An Emacs Dynamic Module for WebKit, aka a fully fledged browser inside emacs
GNU General Public License v3.0
419 stars 24 forks source link

void-function org-link-set-parameters #32

Open mikereape opened 2 years ago

mikereape commented 2 years ago

Hi

I keep getting the error in the title. If I start Emacs 28.0.50 with emacs-webkit with the --debug-init this is what I get:

Debugger entered--Lisp error: (void-function org-link-set-parameters)
  (org-link-set-parameters "webkit" :store 'webkit-org-store-link)
  require(webkit)
  load-with-code-conversion("/home/mike/.emacs.d/init.el" "/home/mike/.emacs.d/init.el" t t)
  load("/home/mike/.emacs.d/init" noerror nomessage)
  startup--load-user-init-file(#f(compiled-function () #<bytecode 0xc1e51fe25d43432>) #f(compiled-function () #<bytecode -0x1f3c686ddc0ce8b5>) t)
  command-line()
  normal-top-level()

Checking the code in webkit.elit does indeed look like org-link-set-parameters is declared and used/referenced further down in the file and in a couple others but never defined anywhere. I'm sure I'm missing the obvious.

I'm not using the pgtkversion if that makes any difference. Otherwise it looks to me like it should go. FWIW, I do use straight.el. I didn't try to get straightor package to handle the build. That was never gonna happen because I had to hunt around for correct libraries for some time. (I wish I could develop on ArchLinux but there you go.) This is on Ubuntu 21.04 where I assume Wayland is used if you are logged into a physical terminal attached directly to the machine. Otherwise, I just RDP into the machine using MS Remote Desktop Connection from a Win 10 box and get whatever RDP gets me. Otherwise, all seems well. I'm so close I can taste it.

One minor thing I can't imagine is relevant is that the build was complaining that I should use a newer version of a library to do with "proxy context" I think (I don't use a proxy) but dpk new nothing about what apt was complaining about so on the off chance I re-ran make and it said there was nothing to do. In particular, the .so file got created.

Speaking of the .so file I suppose (on Ubuntu 21.04) the .so file should go into /usr/local/lib/emacs/28.0.50/webkit/? I was being ambitious because I've come across a lot of posts about how awesome pgtk + native comp is (again good reasons for not using pgtk to do with package managers) and the native comp (which auto-installed its files) put them in a sister directory to /usr/local/lib/emacs/28.0.50/webkit/. If this really is a factor of pgtk being strictly nececessary I think that's reasonable but I don't remember seeing it in the README.

Thanks very much in advance for anything helpful and apologies in advance if I'm just being thick. Thanks especially if you can respond fairly quickly

Best regards Mike

austinweisgrau commented 2 years ago

I think org mode is an undeclared dependency. I got past this error and got webkit somewhat working by installing org mode, at least.

Install here: https://orgmode.org/install.html

If you use use-package, just add this to your config:

(add-to-list 'package-archives
         '("org" . "https://orgmode.org/elpa/") t)
(use-package org
  :ensure t)
akirakyle commented 2 years ago

I didn't intend to make org a hard dependency and kinda assumed it would always be there since it ships with emacs but of course that doesn't mean it'll be loaded. I'll fix this when I have some time.