akiran / react-foundation-apps

Foundation Apps components built with React
http://webrafter.com/opensource/react-foundation-apps
MIT License
292 stars 48 forks source link

Cant include component by their path #9

Closed christophediprima closed 9 years ago

christophediprima commented 9 years ago

Hello,

Tried to add var Offcanvas = require('react-foundation-apps/lib/trigger');

But it cant find it, I have to specify index.jsx but then in this component you also include var PopupToggle = require('../popup/toggle'); And browserify cant find it.

akiran commented 9 years ago

It is working well with webpack. It should also work with browserify.

Are you able to import other components ?

I think you should add option to include jsx extension in your browserify command or config.

On Wed, Mar 4, 2015 at 7:37 PM, dipdipdip84 notifications@github.com wrote:

Hello,

Tried to add var Offcanvas = require('react-foundation-apps/lib/trigger');

But it cant find it, I have to specify index.jsx but then in this component you also include var PopupToggle = require('../popup/toggle'); And browserify cant find it.

— Reply to this email directly or view it on GitHub https://github.com/akiran/react-foundation-apps/issues/9.

christophediprima commented 9 years ago

I am using this yeoman generator : https://github.com/larsonjj/generator-yeogurt

And I am far from being an expert of all these grunt and browserify tasks... :s

christophediprima commented 9 years ago

ok I manage to fix it in browserify grunt config file :+1: