Setting rows property to < 1 or null crashes the app and tab.

akiran / react-slick

React carousel component

http://react-slick.neostack.com/

MIT License

11.76k stars 2.11k forks source link

Setting rows property to < 1 or null crashes the app and tab. #1254

Open blwsh opened 6 years ago

blwsh commented 6 years ago

The app will crash if you set the sliders row property to anything < 1 or null. The row property sometimes needs to be set to 0 so slick doesn't wrap your slide content in a pointless div according to a resolved issue on the slick github repo.

To replicate just add rows: 0 to your settings object.

silicakes commented 6 years ago

Same here. I've tried to use rows: 0 in order to avoid the regression caused by adding an extra row div. The page crashes.

GioLogist commented 6 years ago

Can confirm, happening for me as well - latest stable version.

edzjins commented 6 years ago

Can confirm too, happens on the latest stable version, it's acually unusable for me at this point because of it.

matenka-andrii commented 6 years ago

Same here. Guys is there some way to fix that behavior?

webdevpchoi commented 5 years ago

Confirm this issue is still occurring. Has anyone found a fix for this yet? Having a redundant div is driving me bonkers.

LuisPerez94 commented 5 years ago

Confirm this issue is still occurring

blwsh commented 5 years ago

1 year old this issue. They grow so fast. If I get a moment I’ll try put in a pull request.

l3dger commented 5 years ago

Has a fix for this been released yet?

samturner3 commented 5 years ago

This issue is also blocking solving https://github.com/akiran/react-slick/issues/1539

We can't set the height to be the same for all sides based on the tallest slide without rows: 0

partyconfetti commented 4 years ago

Still crashes and took a lot of time to figure out in a big project...

blwsh commented 4 years ago

Dw! The world will end soon, we can mark this issue as “low priority”

TheHacker66 commented 3 years ago

We almost defeated covid but we can't have a fixed slider in 2021.. I'll see if I can do it and open a PR.

vsdmoraes commented 3 years ago

Same here, sometimes crashes, sometimes open a debugger. Any updates?

JoeJHoward commented 3 years ago

Same here crashes every time. The issue is also without rows: 0 the slider sets inline-block to slides which adds extra height to the slide. Even with line styles I can't overwrite this. See issue below from original slick repo:

https://github.com/kenwheeler/slick/issues/3581

adamcharvat commented 1 year ago

Has anyone found a solution here? This is affecting issue https://github.com/kenwheeler/slick/issues/3581 too.

prosperemebo commented 3 months ago

To address the styling conflicts, I found a workaround:

.slick-track .slick-slide > div {
    property: unset; /* or inherit; */
}

This should help resolve the issues related to conflicting styles.