I believe these lines of code inside inner-slider.jswill cause an infinity loop at prevClickHandler. not entirely sure how I would go abouts fixing it but think would be good to bring to your attention.
It seems to be caused by the componentDidUpdate() which is triggered on load, and any click on the window, or resize of window.
My use case:
I have cards within the slider, if I click on the card, it should navigate to another page. However, just before it does that, an infinity loop occurs from the prevClickHandler.
How to produce loop:
When page loads, componentDidUpdate, when it runs through the first time,
it will go into the !image.onclick condition, and we assign image.onClick to image.parentNode.focus()
When I click around my app, or resize the window, componentDidUpdate() triggers again,
now, my const prevClickHandler is assigned () => { prevClickHandler(); image.parentNode.focus(); };
And NOW, when click an image, the click handler will be calling itself.
I believe these lines of code inside
inner-slider.js
will cause an infinity loop atprevClickHandler
. not entirely sure how I would go abouts fixing it but think would be good to bring to your attention. It seems to be caused by thecomponentDidUpdate()
which is triggered on load, and any click on the window, or resize of window.My use case: I have cards within the slider, if I click on the card, it should navigate to another page. However, just before it does that, an infinity loop occurs from the prevClickHandler.
How to produce loop: When page loads,
componentDidUpdate
, when it runs through the first time,!image.onclick
condition, and we assign image.onClick toimage.parentNode.focus()
componentDidUpdate()
triggers again,const prevClickHandler
is assigned() => { prevClickHandler(); image.parentNode.focus(); };
https://github.com/akiran/react-slick/blob/38c1b51996e2e8ff25d9f6a2241ac3b3034cb86d/src/inner-slider.js#L300
I put a console log