search

akiran / react-slick

React carousel component
http://react-slick.neostack.com/
MIT License
11.76k stars 2.11k forks source link

Removing unnecessary div wrapper on slides #1877

Open akiran opened 4 years ago

akiran commented 4 years ago

Currently, react-slick wraps each slide with div, which deviates from the slick-carousel implementation. So we will remove unnecessary div after fixing other pending issues in this library. Hopefully, we will make a release with this fix in a month or two.

This would be breaking change. When writing CSS be aware that div wrapper on the slide will be removed in future.

Using this issue for tracking progress and discussions related to this change.

AlexMorrisonDev716 commented 3 years ago

Would love to see this completed!

jakepm commented 3 years ago

Is this going to be resolved? Just been around in circles on all the issues referring to this and can't find any mentions of a fix, nor any workarounds that solve the problem for us.

honghainguyen777 commented 2 years ago

I currently face the same problem. Has the react-slick team included the fix into any releases? With the presence of the unnecessary div, the horizontal margin between slides gets removed unexpectedly.

meezin commented 2 years ago

Any update? I'm facing this issue on v0.27.12

ashutosh887 commented 1 year ago

@akiran Should I work on this?