akiran / react-slick

React carousel component
http://react-slick.neostack.com/
MIT License
11.73k stars 2.1k forks source link

May I develop it so that infinite swipe is possible when the values of 'slidesToShow' and 'showElement' are the same, and 'infinite' is set to true? #2328

Closed rjsdnql123 closed 8 months ago

rjsdnql123 commented 8 months ago

Hello. I'm using the react-slick library successfully.

The requirements for my project are to have 9 items(element), with slidesToShow set to 9 so that all elements are visible on the screen, and infinite is set to true.

The expected outcome is to have all elements visible on the screen and be able to slide left and right.

However, I've confirmed that it's not currently functioning as expected.

Looking at the issue list, it seems there are others with similar requirements. Would it be okay for me to try making modifications in this regard?

Related issues

https://github.com/akiran/react-slick/issues/2102

before

image

after

image

Guidelines for posting a new issue

rjsdnql123 commented 8 months ago
rjsdnql123 commented 8 months ago

@akiran If you could check, I will summarize and post my changes. Thank you for creating a great library! :)

akiran commented 8 months ago

Sure. You can send a PR

rjsdnql123 commented 8 months ago

@akiran Could you please review my pull request? : )

https://github.com/akiran/react-slick/pull/2329

akiran commented 8 months ago

Merged #2329

rjsdnql123 commented 8 months ago

Thank you 😄