search

akiran / react-slick

React carousel component
http://react-slick.neostack.com/
MIT License
11.62k stars 2.09k forks source link

[Bug]: unslick is missing in filterSettings #2366

Closed rjsdnql123 closed 2 months ago

rjsdnql123 commented 2 months ago

The unslick property is missing in the filterSettings, so the value of unslick inside InnerSlider is always undefined

rjsdnql123 commented 2 months ago

@akiran
Upon reviewing the code for the pull request submitted earlier, I found an issue indicating a bug. Upon examining the code, I discovered that the unslick property was missing in the filterSettings function, resulting in the unslick property inside InnerSlider being undefined. I have fixed this issue.

This bug appears to manifest as the slider buttons being visible despite all elements being displayed within the slider.

before

image

  1. element 9 
    const settings = {
dots: true,
infinite: false,
speed: 500,
slidesToShow: 10,
slidesToScroll: 3
};

after

image

The problematic code only returns undefined, so the arrow will always be rendered.

image

rjsdnql123 commented 2 months ago

@akiran Without unslick, the expected behavior is not occurring. Could you please confirm this?