search

akiraux / Akira

Native Linux App for UI and UX Design built in Vala and GTK
GNU General Public License v3.0
5.25k stars 202 forks source link

Avoid open cmd terminal running on windows #581

Closed albfan closed 2 weeks ago

albfan commented 3 years ago

Summary / How this PR fixes the problem?

Property for meson build system to run as GUI on windows

Steps to Test

Execute exe on windows and see it doesn't open a cmd terminal to show the logs

Screenshots

N/A

Known Issues / Things To Do

N/A

This PR fixes/implements the following bugs/features:

N/A

Alecaddd commented 3 years ago

I'm getting this while building with meson:

src/meson.build:151: WARNING: Passed invalid keyword argument "win_subsystem".
WARNING: This will become a hard error in the future.
albfan commented 3 years ago

this argument was `gui_app:true prior to meson 0.56. After that version, it is deprecated but still works.

See it on https://mesonbuild.com/Reference-manual.html#executable

Looks that's what happen, seing ubuntu meson package:

https://packages.ubuntu.com/search?keywords=meson

windows msys2 version is patched with +0.56 meson:

https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-akira/Avoid-open-cmd-terminal-running-on-windows.patch

But will rework this to avoid patches for next releases

Alecaddd commented 3 years ago

Converting this to Draft so we know it needs some work. Feel free to mark it ready for a full review once the issue with meson is fixed.

albfan commented 3 years ago

I'm on meson 0.58, should I do conditional compilation for meson >0.56

https://en.wikipedia.org/wiki/Elementary_OS#Summary_table https://packages.ubuntu.com/search?keywords=meson

Is elementary on 0.45?

Alecaddd commented 3 years ago

elementary OS 6 is on v0.53.2