search

akiraux / Akira

Native Linux App for UI and UX Design built in Vala and GTK
GNU General Public License v3.0
5.25k stars 202 forks source link

Follow system theme color dark/light #657

Closed ghost closed 3 years ago

ghost commented 3 years ago

Summary / How this PR fixes the problem?

This will update the theme color dark/light when changed from settings or on launch

Steps to Test

Just change theme color in settings

Known Issues / Things To Do

Nothing

This PR fixes/implements the following bugs/features:

ghost commented 3 years ago

I left the dark-theme schema for the artboard label color

Alecaddd commented 3 years ago

Thanks for the update, but there's still something to fix as it's a bit buggy. If I have follow system OFF, but dark theme ON, when I restart the app, it shows in light mode.

Also, be sure to check all other scenarios users might encounter, like light OS theme with dark mode, or dark OS theme with light mode, switching things around, restarting the app and being sure the user prefs are maintained.

ghost commented 3 years ago

I tested it every thing works.

Alecaddd commented 3 years ago

Thanks for the patch. I updated the code a bit to fix comments and text, and also moved everything in the init_theme method.