We're currently using the Gdk.ModifierType to detect if the CTRL or SHIFT key are pressed.
We randomly use these inside various methods and it's not efficient.
Those modifiers they're not always accurate as they interfere with the OS window management shortcuts and they don't "clear" themselves nicely, resulting in inconsistent behaviors.
We have more efficient methods in the ViewCanvas called ctrl_is_pressed() and shift_is_pressed(), which use the more reliable modifier mask at the time of the interaction (click or keypress) and don't linger around.
We should replace the usage of Gdk.ModifierType.SHIFT_MASK and Gdk.ModifierType.CONTROL_MASK with those methods.
We're currently using the
Gdk.ModifierType
to detect if theCTRL
orSHIFT
key are pressed. We randomly use these inside various methods and it's not efficient.Those modifiers they're not always accurate as they interfere with the OS window management shortcuts and they don't "clear" themselves nicely, resulting in inconsistent behaviors.
We have more efficient methods in the
ViewCanvas
calledctrl_is_pressed()
andshift_is_pressed()
, which use the more reliable modifier mask at the time of the interaction (click or keypress) and don't linger around.We should replace the usage of
Gdk.ModifierType.SHIFT_MASK
andGdk.ModifierType.CONTROL_MASK
with those methods.