search

akireserrano86 / googletransitdatafeed

Automatically exported from code.google.com/p/googletransitdatafeed
0 stars 0 forks source link

Invalid value Europe/Bratislava in field agency_timezone #267

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Here is the error as reported by feedvalidator:

Invalid value Europe/Bratislava in field agency_timezone
"Europe/Bratislava" is not a common timezone name according to pytz version 
2010h
in line 2 of agency.txt

But the TimeZone is listed at http://en.wikipedia.org/wiki/List_of_tz_zones as 
suggested in GTFS.

Original issue reported on code.google.com by ris.d...@gmail.com on 29 Nov 2010 at 7:22

GoogleCodeExporter commented 8 years ago 
Could be related to Bug #615806 in pytz: “Missing Time Zone 
Europe/Bratistava”?

https://bugs.launchpad.net/pytz/+bug/615806

Original comment by ris.d...@gmail.com on 29 Nov 2010 at 7:23

GoogleCodeExporter commented 8 years ago 
The latest release pytz 2010o does recognize the timezone 'Europe/Bratislava'.
If running feedvalidator.py just update the local pytz installation to the 
latest version from http://pypi.python.org/pypi/pytz
The transitfeed windows binary will include the new pytz version in the next 
release.

Original comment by n...@google.com on 30 Nov 2010 at 8:26

GoogleCodeExporter commented 8 years ago 
I can fix this if you don't mind. I think it should check against 
pytz.all_timezones, not only pytz.common_timezones.

Original comment by jiri.semecky on 21 Apr 2011 at 10:49

GoogleCodeExporter commented 8 years ago 
all_timezones would also contain deprecated or historical timezones.

I would prefer a failover solution where we check in all_timezones if the 
timezone ist not found in common_timezones. In this case we should issue a 
warning indicating that the timezones should be changed if possible.

If you like to do that, I would be happy.

Original comment by n...@google.com on 21 Apr 2011 at 11:40

GoogleCodeExporter commented 8 years ago 
Well in my mind Europe/Bratislava is perfectly valid for feeds in Slovakia, it 
is not deprecated nor historical in this sense.

Original comment by ales.pe...@gmail.com on 21 Apr 2011 at 12:01

GoogleCodeExporter commented 8 years ago 
I'm not sure if this is behavior is correct. The GTFS specification refers to 
http://en.wikipedia.org/wiki/List_of_tz_zones as "a list of valid values".

IMO, we should not emit a warning if the feed contains a timezone from this 
list.

Original comment by jiri.semecky on 21 Apr 2011 at 12:04

GoogleCodeExporter commented 8 years ago 
yes in this case thats perfectly true. But there might be other cases which we 
would like to find. As Bratislava is already in common_timezones in the newer 
pytz releases this would not be a warning for very long.

Original comment by n...@google.com on 21 Apr 2011 at 12:04

GoogleCodeExporter commented 8 years ago 
Sounds good to me, closing the issue, then.

Original comment by jiri.semecky on 21 Apr 2011 at 12:18

GoogleCodeExporter commented 8 years ago 
Just double checking the issue. Feedvalidator now emits ERROR for 
Europe/Bratislava TZ, if it would be emmiting a WARNING, I can live with it for 
a while of course.

Original comment by ales.pe...@gmail.com on 22 Apr 2011 at 9:22

GoogleCodeExporter commented 8 years ago

Original comment by bdfer...@google.com on 26 Sep 2014 at 4:45