search

akirk / enable-mastodon-apps

Allow accessing your WordPress blog with Mastodon clients
https://wordpress.org/plugins/enable-mastodon-apps
GNU General Public License v2.0
36 stars 6 forks source link

Linted for wpcom #160

Closed mattwiebe closed 4 months ago

mattwiebe commented 4 months ago

I used phpcs:ignore perhaps a little too liberally, and phpcs may be annoying now with the full WP ruleset, but we can't ship to dotcom without some lint fixes.

I'm going to try to find a way to bypass lint for vendor/bshaffer/oauth2-server-php on wpcom though, because its code style is so radically different, although I did see indication that it's not receiving updates anyway?

mattwiebe commented 4 months ago

I'm happy to ditch the changes to phpcs.dist.xml since it's failing the CS test with a bunch of warnings, or we could adjust the reporting to errors only

akirk commented 4 months ago

I fixed a bunch of warnings.

akirk commented 4 months ago

Thank you very much! I fixed a bunch of warnings, I had already started a similar effort in #156.