search

akirk / friends

A social network between WordPresses. Privacy focused, by itself a self-hosted RSS++ reader with notifications.
https://wpfriends.at/
GNU General Public License v2.0
78 stars 13 forks source link

Bug: All Other Notification Settings are Ignored When `friend_listed` Is Empty #323

Closed logicalor closed 3 weeks ago

logicalor commented 3 weeks ago

In includes/class-admin.php, the process_admin_notification_manager method, there is a clause right at the beginning:

        if ( empty( $_POST ) || empty( $_POST['friend_listed'] ) ) {
            return;
        }

If no friend_listed value is passed, this clause causes all other passed notification settings to be ignored.

This can be fixed by breaking the clause into two and adding the friend_listed value presence check further down the code.