search

akirk / friends

A social network between WordPresses. Privacy focused, by itself a self-hosted RSS++ reader with notifications.
https://wpfriends.at/
GNU General Public License v2.0
81 stars 14 forks source link

Improve PHPCS WordPress compliance #330

Closed akirk closed 3 months ago

akirk commented 3 months ago

This addresses a number of review comments by @apermo. Thank you!

We also discussed that get_transient should be enough for caching, and then I filed https://github.com/WordPress/WordPress-Coding-Standards/issues/2463. As long as that issue is open, I'll keep the doubling of wp_cache_get and get_transient introduced in #329.

We also ran into https://github.com/WordPress/WordPress-Coding-Standards/issues/2299, I preemptively left the phpcs:ignore WordPress.Security.NonceVerification.Recommended there.