Integrating my branch

[The-Compiler]

This is mostly a note to myself - I decided to open it here to make things more discoverable, I hope that's okay!

For a while I've been running my tco branch and didn't find the time to nicely split all my changes into PRs and upstream them... Whoops! With some great recent changes by @laarmen and @hbog, I'm now back on using master, so I should have some motivation to get those integrated :sweat_smile:

Here is a list of commits in there - some of them are most likely already fixed in other ways at this point. Over the upcoming weeks, I'll try to look at those and cross them off here.

• [x] 4516ae8 Use raw strings for regex patterns
  #71
• [x] b8ff42c Handle missing gnupg module gracefully
  Better solution in #65
• [ ] bfc9d94 Don't try to save PGP attachments
  FIXME: how to trigger this?
• [ ] 042a794 Handle UnicodeEncodeError when reading references
  FIXME: how to trigger this?
• [x] 1660673 Show match count in title
  #77
• [x] 034362c Don't crash when gpg signing is aborted
  Superseded by catching all exceptions while sending in 7fa69262d9c778eb39ecb4d15289ab88ee38d63b plus #78
• [ ] 9390aef Fix add_header_line to preserve empty line
  Also see #50
• [x] 5c06daa Don't crash when gpg signing is aborted
• [x] b489317 Use notmuch to get attachment contents
  #79
• [x] 4986238 Fix opening links with target=_blank
  #85
• [x] efb2b8e Add tooltips for tags
  #83
• [x] 8259b69 Fix encoding for HTML view
  should be superseded by #58
• [x] 28b89b4 WIP: show message ID
  #81
• [x] 9ad575f Update all columns correctly
• [ ] ff09803 Fix crash with signature without user ID
  FIXME: how to trigger this?
• [x] 627ec12 search: Only update current index when tagging
  Superseded by #54
• [x] 830aefa Add settings.html_confirm_open_links_trusted_hosts
  #80
• [x] bbe577c Implement per-tag color overrides
  #72
• [x] d8c3baa Fix crash on empty search
  #82 (simpler approach)

[The-Compiler]

Some more notes to myself for follow-up work:

• [x] #71 will conflict with #76
• [ ] Review temp file handling and os.remove, probably can be done in a nicer way with context managers for some cases
  Pushed to tempfile-handling, still needs testing as I haven't configured an external file picker so far
  TODO: Review .eml compose temp file and attachment handling (after #79)
• [x] gnupg.py could use a custom GnupgError instead of just raise Exception. Those could also be handled and displayed by the UI more nicely, rather than exception ... (traceback on stderr).
  #86

[The-Compiler]

First batch cleaned up and turned into PRs :sweat_smile:

For the remaining changes, it's either:

• A bugfix for a bug I don't know how to trigger anymore (whoops...)
• Something that'll conflict too much with an already open PR, and I'll get back to once that's merged
• Not relevant anymore after the changes since merged to master

For the remaining bugfixes, I'll run without those commits myself for a while and hope I can trigger them again - but it's entirely possible they also got fixed in master already since.