akivajgordon / tikkun.io

The online tikkun you always wanted, but never had.
https://www.tikkun.io
MIT License
44 stars 18 forks source link

Add experimental dark mode #75

Closed akivajgordon closed 3 years ago

akivajgordon commented 3 years ago

Note: this is currently an experimental/hidden feature.

TL;DR – toggle experimental dark mode by double-tapping anywhere in the main text area

Why is this feature being added?

I have set my computer and mobile to use dark mode during the nighttime for the past year. I find it to be pretty comfortable, and I expect apps that I use to respect my setting and offer the dark mode. I think others are expecting it too.

I also tend to do most of my Torah reading studying during the night time, and that means I've been staring at this tikkun with bright lights shining on my face. This is an attempt to see if dark mode makes sense for this app.

Why is it experimental?

  1. In the past, I have tried to simulate this by inverting colors on my Mac; however, I've found it to be an unconvincing and unrealistic experience. This is an attempt to give full support to dark mode and see if it can be made to be not that bad.
  2. Our eyes perceive white text on a dark background to be bolder, and it is very obvious after playing with this feature in the tikkun on my desktop. It is quite difficult to read the text, and I don't have a thinner version of the font to use in dark mode. So I'm curious what feedback I'll get.

I want to get it into a few people's hands to get some feedback before making it standard immediately. I really don't want to have to take it away, if need be, from some people who have become dependent on it, so I want to make sure it really works first.

So how do I use this experimental feature?

You can toggle dark mode by double-tapping anywhere on the main text area (where the Torah/Chumash text is displayed). Some people will inevitably accidentally enable it, but I'm guessing most won't off the bat. This way I don't have to commit to any particular UI placement for a dedicated button until it is settled to keep this feature in the app.