search

akivajgordon / tikkun.io

The online tikkun you always wanted, but never had.
https://www.tikkun.io
MIT License
44 stars 18 forks source link

Az Yashir Layout #77

Closed sharshi closed 3 years ago

sharshi commented 3 years ago

Fix #6

Tikkun Reference: https://hebrewbooks.org/pdfpager.aspx?req=50656&st=&pgnum=79

Result:

Screen Shot 2021-03-02 at 9 48 07 PM
akivajgordon commented 3 years ago

@sharshi – thank you so much for the PR! (by the way, I checked out your profile and saw your tikkun project, really cool!)

I want to incorporate these changes, as the אז ישיר broken layout has always bugged me. I have one concern though: the JSON file that you edited is actually an autogenerated file from a different repo that I haven't yet published publicly. So if I re-run that build process, it will overwrite these changes.

I think we would need to incorporate the spirit of these changes in that repo.

sharshi commented 3 years ago

Thanks! Just wanted to provide this as a possible solution - I noticed it was your oldest open issue. So use whatever will help.

Your project inspired me to revamp mine as it has been left alone for several years.

akivajgordon commented 3 years ago

Well I really appreciate the effort. I'm going to close this PR for now but it stays in Github's PR history, and B"H will find a way to credit your efforts if this issue gets closed.