Closed lord-ne closed 3 years ago
@lord-ne I think it's a great suggestion. My initial thought with it was to keep things clean for a computer screen which is already harder on the eyes, plus that when you toggle the nikkud and trop back and forth, the distinctions are less clear when the crowns also are appearing/disappearing.
That being said, I recognize the value of having the Torah side appear as naturally as it would appear in the Sefer Torah, so if you'd like to make a pull request, I'd be happy to give it a review to see if my thought was just a bad theory and that it really is better in practice.
Sounds good. I won't have time to make a PR for a couple weeks at least (I don't have much experience with JavaScript so it'll take me a couple hours to figure out how to do it, which I unfortunately don't have time for right now), so if anyone else wants to do it in the meantime feel free.
@lord-ne No problem. I actually don't think it's too tricky, so I'll give it a stab tonight. And if it does turn out to be tricky, then I'll throw a comment as to why.
@lord-ne So I just tried this out:
I find the resulting appearance to be very underwhelming (the crowns don't appear as large as in a sefer Torah, so much so that I can't even tell how many crowns are on each letter at any reasonable font size); therefore, I don't think it's really worth the added page weight for the additional font, nor the development maintenance cost, nor the distraction for the user who is toggling back-and-forth.
I really appreciate the suggestion, and it was definitely worth the experiment. For now, though, I will close this issue without implementing.
For future reference, in case we want to reopen it at some point, here is the simple diff:
diff --git a/css/master.css b/css/master.css
index b544a8cb..99a60c86 100644
--- a/css/master.css
+++ b/css/master.css
@@ -13,6 +13,11 @@
src: url(/assets/fonts/ShlomosemiStam.ttf);
}
+@font-face {
+ font-family: 'ShlomoStam';
+ src: url(/assets/fonts/ShlomoStam.ttf);
+}
+
* {
box-sizing: border-box;
margin: 0;
diff --git a/css/page.css b/css/page.css
index 6240d067..65078754 100644
--- a/css/page.css
+++ b/css/page.css
@@ -76,6 +76,10 @@
width: 100%;
}
+.tikkun-book.mod-annotations-off .tikkun-page {
+ font-family: ShlomoStam;
+}
+
.tikkun-book.mod-annotations-off .fragment.mod-annotations-on,
.tikkun-book.mod-annotations-on .fragment.mod-annotations-off {
display: none;
The Shlomo Stam font is made to look like handwritten letters in the Torah. The Shlomo semiStam font currently used is a modified version with some of the letter decorations removed or shortened to make it work with nikkudot and trop markings. When cantillation marks are hidden, there is no need to use Shlomo semiStam, so it would look nicer to switch to the Shlomo Stam font with the full decorations.
Source: