akivajgordon / tikkun.io

The online tikkun you always wanted, but never had.
https://www.tikkun.io
MIT License
44 stars 18 forks source link

HEBREW ACCENT TELISHA GEDOLA trope mark is missing #99

Closed etayluz closed 2 years ago

etayluz commented 2 years ago

In tikkun.io - Genesis 37:7 - the first word is displayed as such

Screen Shot 2021-11-24 at 3 12 54 PM

However on Sefaria it appears as such https://www.sefaria.org/Genesis.37.9?lang=he&aliyot=0: image

Any native Hebrew speaker will know that Sefaria's version is correct. The accent should be applied to the NUN and the secondary pashta accent is missing there.

I imagine there are numerous typos like this. What is the source of the text?

I do NOT trust it

akivajgordon commented 2 years ago

@etayluz – thanks for creating this issue!

Yes, it's been frustrating for me as well – I've seen a ton of these errors all over within the source text, which is ironically acquired from Sefaria, e.g.: https://github.com/Sefaria/Sefaria-Export/blob/master/json/Tanakh/Torah/Genesis/Hebrew/Tanach%20with%20Ta'amei%20Hamikra.json

From that source, the verse is given as:

            "וְ֠הִנֵּה אֲנַ֜חְנוּ מְאַלְּמִ֤ים אֲלֻמִּים֙ בְּת֣וֹךְ הַשָּׂדֶ֔ה וְהִנֵּ֛ה קָ֥מָה אֲלֻמָּתִ֖י וְגַם־נִצָּ֑בָה וְהִנֵּ֤ה תְסֻבֶּ֙ינָה֙ אֲלֻמֹּ֣תֵיכֶ֔ם וַתִּֽשְׁתַּחֲוֶ֖יןָ לַאֲלֻמָּתִֽי׃",

So I'd need to get a new source of the text. If you know where I can get access to a machine-parsable (i.e. JSON) format with the corrections, I'd love if you can point me to it.

Thanks!

etayluz commented 2 years ago

What I've noticed is that the text as it appears on Sefaria's website in very much correct and complete. However - their Sefaria-Export dump seems to be a completely different version that is actually based on tanach.io - which is the source of all the errors.

I'll put together a nice json file and attach it later. It will just be a copy and paste of the content from Sefaria's website.

akivajgordon commented 2 years ago

Fixed with #102