akiver / cs-demo-manager

Companion application for your Counter-Strike demos.
https://cs-demo-manager.com
MIT License
1.42k stars 195 forks source link

[2.15] JSON Seconds occurence is being divided by newly noted framerate instead of tickrate #635

Closed lilgandhi1199 closed 10 months ago

lilgandhi1199 commented 1 year ago

OLD "tick": 27857, "seconds": 435.880066 NEW "tick": 27857, "seconds": 217.8125

It was correct before when you divided ticks by "server_tickrate": to get seconds. Now it looks like you are dividing by "frame_rate":

When playing the demo ingame we can see that this kill infact occurs at 435 seconds aka 7m15s image

lilgandhi1199 commented 1 year ago

Note also your kill counts dropped drastically. I just use WinMerge to filecompare your old json to your new ones every version.

"3k_count": 14, "2k_count": 27, "1k_count": 68,

"3k_count": 0, "2k_count": 1, "1k_count": 7,

Trade kills also shifted slightly. And what scares me some is has_won_round has changed in a lot of places too

^^^ Hopefully that was an improvement and not a regression. There has been a change in what the program thinks is the income on round 16

image

image

lilgandhi1199 commented 1 year ago

After adjusting for these differences I can only see that weapon names have changed in some instances (probably more accurate detection right?)

"USP-S" has changed to "P2000" "M4A1-S" has changed to "M4A4" MP5-SD to MP7 R8 Revolver to Desert Eagle...

lilgandhi1199 commented 1 year ago

image This looks like a huge (albiet trivial) oversight in tallying. Because it doesn't seem like these occurrences are actually missing in the log.

image Or again they became more accurate. I can't tell

akiver commented 10 months ago

A new major version has been released, closing the issue 🧹