akiver / cs-demo-manager

Companion application for your Counter-Strike demos.
https://cs-demo-manager.com
MIT License
1.45k stars 195 forks source link

K/D is counting average instead of correct formula #960

Closed milkywayfarer closed 6 days ago

milkywayfarer commented 2 weeks ago

What problem is this solving

KDR column (named K/D) in the table does not count KDR according to the kills and deaths from the filtered results, but rather uses an average of all matches. This yields mixed results.

For example, we played 3 matches, and I filter that day using the calendar in Players view.

First match player's K/D is 1.75, second is 3.22, third is 1.33. Player ended 3 maps with 97 kills and 55 deaths, thus K/D is ~1.763, but Demo Manager shows 2.1.

Proposed solution

I believe we should not use the average but rather get the resulting sum of kills and deaths after the filter is applied and then get the correct result.

Describe alternatives you've considered

No response