[Feat request] Support line padding without messing up glyphs

[pro-anon]

This is how kitty looks like with modify_font cell_height 200%

This is how goneovim looks like after setting linespace=20

[bfulop]

In my understanding, this is a feature unique to Kitty. It will scale up certain glyphs (e.g. vertical separator line) to be 100% "line height".

[pro-anon]

I think so yeah. This is how VS Code looks like if you set the "editor.lineHeight" to 38 to add some padding.

I don't think it stretches out the unicode symbols? But it's not a terminal app so maybe they have more flexibility in their rendering so that they can increase the line padding without affecting the text inside each line.

A workaround that I've found is using vim.g.goneovim flag to change my separator glyph. But stuff like the telescope menu look a bit weird.

[akiyosi]

Hi, Thanks for this issue report :) I believe it is possible to scale specifically for some glyphs in goneovim as well. I will try it.

[akiyosi]

https://github.com/akiyosi/goneovim/actions/runs/4392964666

I have implemented this feature as a trial, please try it out. Any feedback would be appreciated.

[bfulop]

Thank you @akiyosi for working on this!

I always wished to have this feature exist in Goneovim!

The glyph vertical scaling is already looking great in the test build. 🎉

There are a few issues I noticed:

1. the biggest issue is that the letter a is replaced by some different font (I'm using Iosevka Term font)

2. There's some gap in the left pointing triangle:

3. The border edges don't align (e.g. in telescope):

Thanks again for working on this! ❤️

[pro-anon]

Same issues as @bfulop With a different font:

[akiyosi]

@pro-anon @bfulop

I have updated this feature.

https://github.com/akiyosi/goneovim/actions/runs/4397528120

The "a" character was being scaled because the "a" character was also scaled in the implementation for testing purposes. In this new feature, the character to be scaled can be set in the configuration file settings.toml. The default setting is as follows

[bfulop]

Thank you so much, that was fast! It's looking great on my machine!

I can now remove the DrawWindowSeparator option from config. 🎉 The only reason I had it on was to have the continous separator line between splits.

[pro-anon]

Works perfectly!

[bfulop]

Hello @akiyosi ,

I was wondering if this feature could be included in the nightly releases?

I tested previous nightlies and did not see this applied. I just tried testing it again with the currently latest nightly but this release does not open on my Mac.

[akiyosi]

@bfulop This has not yet been merged. This change may have a slight performance impact and I am reviewing it closely.

[akiyosi]

merged.