akiyosi / goneovim

A GUI frontend for neovim.
MIT License
2.34k stars 60 forks source link

Noevim 0.9 winbar and smooth scrolling #456

Closed bfulop closed 1 year ago

bfulop commented 1 year ago

Hello,

I'm using Lspsaga to display the current document's path in the Neovim Winbar.

When using the smooth scrolling, the winbar seems to scroll together with the document, then snap to the top, when the scrolling has finished. The end result is that there seems to be a flickering of the winbar when scrolling the buffer.

Not sure if it's possible to add support for the winbar on the Goneovim side? It would be great if it could be excluded from the scrolling?

Thank you!

akiyosi commented 1 year ago

@bfulop Hi, Thanks for this report. I have created a fix to keep winbar rows from scrolling in smooth scrolling. Any feedback on the behavior would be appreciated.

https://github.com/akiyosi/goneovim/actions/runs/4674981168

bfulop commented 1 year ago

Thank you for the quick fixing!

It's working great on my machine. The winbar is no longer jumping with the scrolling but is always fixed to the top of the screen.

bfulop commented 1 year ago

I just had my first "cold crash" ever of Goneovim! Not sure if it's related to this change.

I was just accepting a code suggestion by hitting TAB, and Goneovim just quit. I keep testing and report back if I continue to experience stability issues.

Edit:

Had to remove the swap file from disk (using MacOS) otherwise Goneovim would quit immediately when trying to open that file.

bfulop commented 1 year ago

Goneovim crashes when I try to accept a suggestion from Codeium.

It only happens with this build.

I tried the build from the latest release and it doesn't have this issue.

akiyosi commented 1 year ago

@bfulop Thanks for confirming.

If possible, could you run goneovim from the command line to reproduce the problem and if you see a stack trace at the time of the crash, could you share it with me?

bfulop commented 1 year ago

Here's the log file.

Goneovim closes after this line:

2023/04/13 10:26:13.828649 807661.468 finished creating word cache: 'data_fetching_not_yet_im

At this point, I pressed TAB to accept the Codeium suggestion.

codeium-crash.log

There's another way to reproduce the same behaviour (Goneovim auto-closing):

If I have a leftover swap file in (because of a previous crash) ~/.local/state/nvim/swap/%Users%balint.fulop%Desktop%somefile.ts.swp

and I try to open this file:

If I do:

:e ~/Desktop/somefile.ts

No issue, Goneovim does not close. ✅

If I try to open this file from the Telescope file picker, then Goneovim will close automatically. ❌

Here's the log file. Note that I did several attempts to reproduce the issue.

existing-swap-file-crash.log

akiyosi commented 1 year ago

@bfulop Thanks for the info. I found the cause and fixed it.

https://github.com/akiyosi/goneovim/actions/runs/4690693598

bfulop commented 1 year ago

Thank you @akiyosi!

I've been using this build all day and didn't have any stability issues! ✅

akiyosi commented 1 year ago

Closed. Reopen if you have any problems.