search

akiyosi / goneovim

A GUI frontend for neovim.
MIT License
2.36k stars 59 forks source link

Goneovim setting.toml to settings.toml #481

Open vabenil opened 1 year ago

vabenil commented 1 year ago

It seems since v0.6.5 goneovim reads settings from settings.toml instead of setting.toml. When I updated smooth scrolling and other features stopped working and it seems it was because of this change.

After moving setting.toml to settings.toml the issue was solved but since I did not see mention of this anywhere else I decided to post the issue here.

Suggestion

Maybe it would be a good idea to create a default settings.toml if none is found.

akiyosi commented 1 year ago

Hi, Thanks for this issue report.

Currently goneovim has a behavior specification that reads settings.toml if setting.toml does not exist. This is due to the need for a transition period related to the specification when changing the config file name from setting.toml to settings.toml in the past. I imagine that this may have surfaced in your environment because v0.6.5 changed the specification regarding the location of the Windows settings file.

I will remove the setting.toml loading process in v0.6.6.

vabenil commented 1 year ago

So in 0.6.5 it should still continue working even if the settings file is named setting.json? Also I am using Arch Linux not Windows.

akiyosi commented 1 year ago

Yes. Maybe if you use HEAD, there will be a fix somewhere in the future, though.