akiyosi / goneovim

A GUI frontend for neovim.
MIT License
2.41k stars 63 forks source link

frame rate #491

Open ogios opened 1 year ago

ogios commented 1 year ago

Hi, great work, really impressed by the minimap and all the ext stuff. I have goneovim and neovide installed, both have their own specialties.

I'm wondering if there's a way to manually set the frame rate like neovide does, which will definitely provide a better feeling when coding.

akiyosi commented 1 year ago

@ogios Hi Currently it is not possible to set the frame rate. Goneovim will attempt to use as much machine power as possible to achieve performance as requested.

I'm wondering if there's a way to manually set the frame rate like neovide does, which will definitely provide a better feeling when coding.

Does goneovim have slow scenes on your machine?

ogios commented 1 year ago

not exactly, just qt can not be over 60fps by default, but I have a 144hz screen so I want to make it smoother.

akiyosi commented 1 year ago

Hmmm, is there any references that Qt does not exceed 60 fps by default?

ogios commented 1 year ago

Hmmm, is there any references that Qt does not exceed 60 fps by default?

sorry i didn't check it in qt's documentation, i just google it and then asked claude ai. image

akiyosi commented 1 year ago

@ogios The above view of AI seems to be a summary view based on the fact that most common hardware, such as monitors, default to 60 fps, and that it is not specified in the Qt specification.

Would your argument be the following points?

ogios commented 1 year ago

Would your argument be the following points?

  • Compared to other 144fps-capable applications, goenovim is experienced as having a frame rate that is less than 144fps. So, Goneovim may be running at a limited fps due to some factor.

yes, exactly

akiyosi commented 1 year ago

@ogios The UI of the goneovim is not continuously drawn at a constant frame rate, as is often the case in video games, but is updated as necessary when there is a request for drawing updates. One possibility is that your machine's maximum key repeat rate is less than 144 times per second. This is because the Neovim screen is essentially updated when some key input occurs.

I have created a binary that allows visualization of the FPS of the goneovim.

https://github.com/akiyosi/goneovim/actions/runs/5816026745

You can visualize the FPS by running goneovim in debug mode as follows;

/path/to/goneovim --debug

I think this can be used to isolate the problem you reported.

ogios commented 1 year ago

@akiyosi thanks, i'll look into it