akiyosi / goneovim

A GUI frontend for neovim.
MIT License
2.39k stars 61 forks source link

Floating panels have lost transparency on latest nightly #527

Closed bfulop closed 6 months ago

bfulop commented 6 months ago

Hello,

I've been testing the latest nightly build this morning and noticed that the floating menus no longer display any transparency.

On the previous nightly release, I was happy to see that even the bordered Telescope windows had shown correct transparency (re #483). It was not totally stable though, sometimes the transparency would revert back to the rendering as described in #483.

I'm using NVIM v0.9.5.

BalintFulop 2024-03-11--10-29-13@2x

akiyosi commented 6 months ago

@bfulop Hi :)

I intend to have corrected the specifications regarding transparency processing in Neovim and the transparency settings of Goneovim itself, as well as the behavior when applying blur effect effects, in the latest build. In the previous build, some processing was not accurately executed. However, there might still be cases that have not been considered, and I would like to improve upon such points if they exist. As a premise, the transparency of Neovim windows is distinguished by the type of window, so please allow us to discuss it differently according to the case.

First, what is displayed in the screenshot you provided I believe is the popup-menu. In Neovim, the transparency setting of the popup-menu is basically controlled by an option called pumblend. Please check your current setting of pumblend and the behavior when you change this value. To check the current value: echo &pumblend To change the setting: set pumblend=40

Next, regarding the transparency of normal float windows. The transparency of normal float windows is controlled by the winblend option. Please check your current setting of winblend and the behavior when you change this value. To check the current value: echo &winblend To change the setting: set winblend=30

Next, regarding the transparency of the UI provided by Telescope. The transparency of Telescope's UI is either referred to winblend or set within Telescope's configuration.

Lastly, regarding the transparency of the message window. This setting is currently set in Goneovim's configuration. e.g.

[Message]
Transparent = 0.5

Could you please organize your issue by window type as mentioned, and let us know in which cases the problem occurs?

bfulop commented 6 months ago

Hello @akiyosi,

Thanks for the detailed reply and sorry if I wasn't specific enough.

What I wanted to report is that it looks like there's a regression in the transparency rendering since the last nightly I tested (from last week).

Last week all the transparency settings worked great, even the "double-layered" telescope transparency issue we discussed in #483.

With the latest nightly I do not see any transparency in Goneovim, while they all continue to work inside the terminal Neovim (or previous versions of Goneovim). I checked pumblend (popup from neovim command line), and winblend (in lspsaga completions and telescope).

akiyosi commented 6 months ago

@bfulop Ah, upon checking again, I realized there was an oversight. If the overall transparency setting for the editor was not applied, the process was such that the transparency color would not be reflected in float windows or popup menus😂 This issue has been fixed in https://github.com/akiyosi/goneovim/actions/runs/8235942338.

bfulop commented 6 months ago

Great news, thank you @akiyosi! I just downloaded the latest nightly and it works perfectly! Thanks for the quick fix!