search

akjoshi / oohembed

Automatically exported from code.google.com/p/oohembed
Other
0 stars 0 forks source link

Vimeo scheme URL is wrong #1

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I just noticed that the original url scheme I gave for Vimeo is wrong.

http://www.vimeo.com/groups/*/*
should be
http://www.vimeo.com/groups/*/videos/*

Original issue reported on code.google.com by BDoughe...@gmail.com on 13 Jan 2009 at 9:16

GoogleCodeExporter commented 9 years ago 
Internally, it is regex based & [the regex for vimeo][1] is actually very 
generic. 

So it is just a matter of fixing the documentation on the oohembed.com home 
page,
right? Unless you'd prefer that the regex be tightened too.

[1]:
http://code.google.com/p/oohembed/source/browse/trunk/app/provider/oembedprovide
r.py?r=2#93

Original comment by deepak.s...@gmail.com on 14 Jan 2009 at 2:33

GoogleCodeExporter commented 9 years ago 
Sorry, I hadn't noticed that the regex wasn't specific. It should be fine just 
changing it on the home page.

Original comment by BDoughe...@gmail.com on 15 Jan 2009 at 4:21

GoogleCodeExporter commented 9 years ago 
Fixed in r3!

Original comment by deepak.s...@gmail.com on 16 Jan 2009 at 3:20