akjoshi / oohembed

Automatically exported from code.google.com/p/oohembed
Other
0 stars 0 forks source link

yfrog provider missing width/height, video support: should pass through to yfrog's own provider #20

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Go to oohembed result for a yfrog image:
http://www.oohembed.com/oohembed?url=http://yfrog.com/f5fjuhj

What is the expected output? What do you see instead?

Photo output must include width and height parameters per oEmbed spec, but they 
area missing here. The good news is, yfrog now has their own oembed endpoint 
which includes that information:

http://code.google.com/p/imageshackapi/wiki/OEMBEDSupport

Sample:
http://www.yfrog.com/api/oembed?url=http://yfrog.com/f5fjuhj

It should be possible to replace the current yfrog photo and video provider 
code with a passthrough. (yfrog's pages don't include discovery links, so 
services like StatusNet will still need to fall back to oohembed.)

Warning: yfrog's own oembed responses do not include the thumbnail_width and 
thumbnail_height parameters, although the spec requires them if thumbnail_url 
is present.

Original issue reported on code.google.com by brion.vi...@gmail.com on 10 Nov 2010 at 1:24

GoogleCodeExporter commented 9 years ago
Changed YFrog support to utilize their oembed endpoint, i.e. passthrough mode.

Original comment by deepak.s...@gmail.com on 19 Nov 2010 at 2:01