search

akka-js / akka.js

Akka, for Scala.js
http://akka-js.org
474 stars 39 forks source link

Fastparse binary compatibility issue. Conflict with scalapb. #77

Closed LogicalTime closed 6 years ago

LogicalTime commented 7 years ago

I get linking errors when using scalapb and akkajs. They are on fastparse 0.4.2 and you are on 0.4.4 now. fastparse.all$.CharsWhile() is removed between 0.4.2 and 0.4.4. Fastparse documentation says it's not binary compatible. Perhaps we should all them to release a binary compatible 1.0.x. Parboiled2 is released for Scalajs I believe (check out scala-uri's dependencies).

andreaTP commented 7 years ago

Thanks for the report! Actually fast parse is a transitive dependency front shocon. I'm not really sure how to target this issue... Downgrading and releasing shocon with fast parse 0.4.2 looks really a temporary workaround... 🙁 cross releasing doesn't sound as an option... Any idea?

andreaTP commented 7 years ago

BTW did you give a try explicitly excluding fast parse from Akka. Js import?

andreaTP commented 7 years ago

I have just checked in one of my projects and I do not find problems in scalapb + akka.js could you provide a minimal repro please? So that I can check what is happening more in depth.

LogicalTime commented 7 years ago

Yes, I'll get on that tomorrow if I can. I asked fastparse's author to see if he is up for going to a major release that is binary compatible. Did you do scalapb's Scalajs dependency and go for fastparse 0.4.4?

andreaTP commented 7 years ago

aaa, sorry, I have understood the other way around, ok updating shocon to 0.4.4 is totally feasible!

Feel free to take the chance to make a PR, or I will do it before 1.2.5.5 release.

I leave this open until shocon is updated.

Thanks for the report.

andreaTP commented 7 years ago

actually, PR sent: https://github.com/unicredit/shocon/pull/25

LogicalTime commented 7 years ago

Just thought I'd mention that fastparse released 1.0 0 which is identical to 0.4.4 and should be binary compatible going forwards. So this issue is closed as soon as you update to a shocon version that uses fastparse 0.4.4 or 1.0.0.

andreaTP commented 7 years ago

ok, I make the PR on shocon and try to integrate it when 2.5.7 is out.

andreaTP commented 7 years ago

here you have: https://github.com/unicredit/shocon/pull/27

andreaTP commented 6 years ago

A little late but Akka.Js 1.2.5.8 is out and should solve this, please try it out and feel free to reopen in case.