search

akka-js / shocon

Simple pure-scala Typesafe HOCON implementation using FastParse
Apache License 2.0
74 stars 21 forks source link

Migrated Typesafe Config facade into separate dependency project (Res… #31

Closed darkfrog26 closed 6 years ago

darkfrog26 commented 6 years ago

Resolves https://github.com/akka-js/shocon/issues/22

andreaTP commented 6 years ago

that was fast! give me a little to check everything ;-)

darkfrog26 commented 6 years ago

No problem. I didn't really change any code, just moved things around and added another cross project to SBT.

darkfrog26 commented 6 years ago

BTW, it doesn't look like your tests are running. I'm not sure if that's my fault or not...

darkfrog26 commented 6 years ago

@andreaTP any updates on this? It's blocking a new release of my Profig project.

andreaTP commented 6 years ago

ok, let me have a look

andreaTP commented 6 years ago

@darkfrog26 do you mind to enable travis?

darkfrog26 commented 6 years ago

@andreaTP I don't understand...it's showing that Travis built successfully for this PR

andreaTP commented 6 years ago

the approach looks good but I will keep the name shocon for the facade. do you mind to rename shocon -> shocon-parser and facade -> back to shocon ?

andreaTP commented 6 years ago

you are right on travis, my bad.

darkfrog26 commented 6 years ago

Done

darkfrog26 commented 6 years ago

I didn't change the variable name in the build, but the artifacts are modified.

darkfrog26 commented 6 years ago

if you want the variables renamed just let me know.

andreaTP commented 6 years ago

LGTM

andreaTP commented 6 years ago

I'll try to release soon.

darkfrog26 commented 6 years ago

Thanks, I appreciate it.