search

akka / akka-grpc

Akka gRPC
https://doc.akka.io/docs/akka-grpc/
Other
432 stars 123 forks source link

Run source code formatter on jenkins #119

Open raboof opened 6 years ago

ignasi35 commented 5 years ago

How would this work?

  1. Should the build fail when a file with invalid source formatting is found? (this is what Lagom does)
  2. Should Jenkins fix the formatting and commit the changes?
raboof commented 5 years ago

I think '1' is reasonable (though '2' could be neat, I'm not sure I find it worth the complexity, and it might have some downsides as well)

dwijnand commented 5 years ago

The best first step here is commit a formatting config to the repo and format it all.

Then it can be decided if CI should fail or amend ill-formatted PRs.