search

akka / akka-grpc

Akka gRPC
https://doc.akka.io/docs/akka-grpc/
Other
431 stars 123 forks source link

Select client/server/both #155

Closed 2m closed 6 years ago

2m commented 6 years ago

https://github.com/akka/akka-grpc/pull/154#discussion_r179753307

2m commented 6 years ago

I think this is a concern in the sbt plugin as well. Currently it is possible to select what to generate, but requires configuring multiple settings to achieve the desired result. We need something more user friendly to select from the {java,scala} x {client,server}.

patriknw commented 6 years ago

@raboof is this done?

raboof commented 6 years ago

java/scala switching is done, but client/server/both switching not yet (it currently defaults to 'both').

patriknw commented 6 years ago

What is the reason for having a Seq for akkaGrpcGeneratedLanguages? Doesn't make much sense to generate both java and scala, since class names will be conflicting?

raboof commented 6 years ago

If you disable the flat_package option the class names no longer conflict. This seems like it could be convenient in some cases (for example we use this in the interop testing project)

patriknw commented 6 years ago

ok, then there is a valid reason

patriknw commented 6 years ago

seems like the gradle plugin puts the message files in wrong directory: plugin-tester-scala/build/generated/source/proto/main/scalapb/example/myapp/helloworld/grpc/HelloReply.scala

The service classes are right.

patriknw commented 6 years ago

ah, it's scalapb vs akkaGrpc (I was expecting everything together)