search

akka / akka-grpc

Akka gRPC
https://doc.akka.io/docs/akka-grpc/
Other
431 stars 124 forks source link

Code generation parameter: map method names #239

Open raboof opened 6 years ago

raboof commented 6 years ago

When a protocol uses method names that clash with method names already reserved by the JVM, we should allow configuring the codegen to avoid those names in the generated code (but still use them in the protocol logic).

Look at how protoc/scalapb handle this for model fields for inspiration.

johanandren commented 6 years ago

Or maybe fail fast on those names. To clarify for example notify, notifyAll are kind of easy to forget are taken and could also easily overlap with a problem domain, toString, hashCode, wait, finalize, getClass, equals maybe less so but still nice if it failed fast with a clear error about not using those.