search

akka / akka-grpc

A platform to build and run apps that are elastic, agile, and resilient. SDK, libraries, and hosted environments.
https://doc.akka.io/libraries/akka-grpc/current/
Other
431 stars 124 forks source link

LoadBalancingIntegrationSpec: should re-discover endpoints on failure #935

Open ignasi35 opened 4 years ago

ignasi35 commented 4 years ago

I've seen unrelated PR's fail the test akka.grpc.scaladsl.LoadBalancingIntegrationSpec.

See https://travis-ci.org/github/akka/akka-grpc/jobs/678093242 (triggered by #933 "Update grpc-core, grpc-interop-testing, ... to 1.29.0")

See https://github.com/ignasi35/akka-grpc/tree/require-akka-2.6 (bumps Akka to 2.6)

NOTE: the failures observed on each case have completely different symptoms.

ignasi35 commented 4 years ago

See ignasi35/akka-grpc@require-akka-2.6 (bumps Akka to 2.6)

Ths issue there is not a real issue. The test was not properly ported: the test requires 2 different Materializer instances and the code rewrite broke the requirement.

See travis-ci.org/github/akka/akka-grpc/jobs/678093242 (triggered by #933 "Update grpc-core, grpc-interop-testing, ... to 1.29.0")

The issue was caused by a behavior change in the underlying grpc-java.

raboof commented 4 years ago

The test is also flakey: https://travis-ci.org/github/akka/akka-grpc/jobs/682825264

raboof commented 4 years ago

The non-flakey problems are now solved.

The test is still flakey: again at https://travis-ci.org/github/akka/akka-grpc/jobs/691288184