search

akka / akka-http

The Streaming-first HTTP server/module of Akka
https://doc.akka.io/docs/akka-http
Other
1.34k stars 594 forks source link

Bump h2spec external binary to newer versions #3534

Open ignasi35 opened 4 years ago

ignasi35 commented 4 years ago

In #1578 there was some initial work to update the build to use a newer version of https://github.com/summerwind/h2spec/. That work focused on the build.

I've just replaced the binary in ./akka-http2-support/target/h2spec_darwin_amd64/h2spec with the latest and ran H2SpecIntegrationSpec. Tests, as they are now, fail because the binary API has changed from:

https://github.com/summerwind/h2spec/tree/9b3d1a5078cb4003506bd8004eb1b01e3be2a3e7

to

https://github.com/summerwind/h2spec/#usage

The parameter -s: Section number on which to run the test. (Example: -s 6.1 -s 6.2) is not available in h2spec since version 2.0.0. As a consequence, the execution of H2SpecIntegrationSpec goes over tests we don't need taking (a lot) longer and reporting failures we would ignore anyway.

raboof commented 4 years ago

The parameter -s: Section number on which to run the test. (Example: -s 6.1 -s 6.2) is not available in h2spec since version 2.0.0.

It looks like it's no longer under a '-s' flag, but just a regular parameter now, so you can for example:

h2spec http2/6.3