HTTP2: Respect SETTINGS_ENABLE_PUSH

ktoso commented 7 years ago

SETTINGS_ENABLE_PUSH (0x2): This setting can be used to disable server push (Section 8.2).

An endpoint MUST NOT send a PUSH_PROMISE frame if it receives this parameter set to a value of 0.
(client) An endpoint that has both set this parameter to 0 and had it acknowledged MUST treat the receipt of a PUSH_PROMISE frame as a connection error (Section 5.4.1) of type PROTOCOL_ERROR.

The initial value is 1, which indicates that server push is permitted. Any value other than 0 or 1 MUST be treated as a connection error (Section 5.4.1) of type PROTOCOL_ERROR.

ktoso commented 7 years ago

Simple handling done, we don't yet emit PUSH_PROMISE so I did not test / go that far with it. Let me know if we would rather have this fully complete or fill in the missing bit later (I opt for later).

jrudolph commented 7 years ago

Agreed, not needing right now.

akka / akka-http

HTTP2: Respect SETTINGS_ENABLE_PUSH #775